Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pfed-sso: Enable bearer token authentication #811

Merged
merged 14 commits into from
Oct 16, 2023
Merged

Conversation

dankle
Copy link
Contributor

@dankle dankle commented Sep 25, 2023

  • Enabling usage of bearer access token through the concord API.
  • Fetching sub from profile instead of token. Tokens can be valid even though there is no sub claim attached to the token.
  • Adding allow list for bearer tokens based on clientIds.
  • Adding capability to disable bearer tokens.

@dankle dankle changed the title Enable bearer token api auth Enable bearer token authentication Sep 25, 2023
@benbroadaway benbroadaway changed the title Enable bearer token authentication pfed-sso: Enable bearer token authentication Sep 25, 2023
brig
brig previously approved these changes Sep 26, 2023
amithkb
amithkb previously approved these changes Sep 27, 2023
@amithkb
Copy link
Contributor

amithkb commented Sep 27, 2023

LGTM

@dankle dankle dismissed stale reviews from amithkb and brig via b7825a1 October 6, 2023 22:17
@dankle dankle requested a review from amithkb October 12, 2023 04:53
@dankle dankle requested a review from benbroadaway October 12, 2023 15:08
@ibodrov ibodrov merged commit e8ec417 into master Oct 16, 2023
1 check failed
@ibodrov ibodrov deleted the enable_jwt_api_auth branch October 16, 2023 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants